linux-kernel - Re: [PATCH] kernel: kexec_file: remove some duplicated include file

Open Source and information security mailing list archives

Message-ID: <20180921023529.GQ2555@MiWiFi-R3L-srv>
Date:   Fri, 21 Sep 2018 10:35:29 +0800
From:   Baoquan He <bhe@...hat.com>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     ebiederm@...ssion.com, kexec@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: kexec_file: remove some duplicated include file

On 09/21/18 at 10:27am, zhong jiang wrote:
> On 2018/9/21 10:15, Baoquan He wrote:
> > On 09/20/18 at 01:12pm, zhong jiang wrote:
> >> kexec.h and slab.h have duplicated include. hence just remove
> >> redundant file.
> > They have duplicated include, why do you remove both of them?
> because we include the kexec.h and slab.h twice in kexec_file.c. It's unnecessary.

OK, Could you rewrite the log with this? The old log makes me think
kexec.h and slab.h themselves have duplicated include.

> 
> Thanks,
> zhong jiang
> >> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> >> ---
> >>  kernel/kexec_file.c | 2 --
> >>  1 file changed, 2 deletions(-)
> >>
> >> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> >> index c6a3b68..35cf0ad 100644
> >> --- a/kernel/kexec_file.c
> >> +++ b/kernel/kexec_file.c
> >> @@ -25,8 +25,6 @@
> >>  #include <linux/elf.h>
> >>  #include <linux/elfcore.h>
> >>  #include <linux/kernel.h>
> >> -#include <linux/kexec.h>
> >> -#include <linux/slab.h>
> >>  #include <linux/syscalls.h>
> >>  #include <linux/vmalloc.h>
> >>  #include "kexec_internal.h"
> >> -- 
> >> 1.7.12.4
> >>
> >>
> >> _______________________________________________
> >> kexec mailing list
> >> kexec@...ts.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/kexec
> > .
> >
> 
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives