linux-kernel - Re: [PATCH 3.16 20/63] scsi: sg: allocate with __GFP_ZERO in sg_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000000000000025c4a05766ab6be@google.com>
Date:   Fri, 21 Sep 2018 17:19:35 -0700
From:   syzbot <syzbot+7d26fc1eea198488deab@...kaller.appspotmail.com>
To:     Ben Hutchings <ben@...adent.org.uk>
Cc:     akpm@...ux-foundation.org, ben@...adent.org.uk,
        dgilbert@...erlog.com, glider@...gle.com, jthumshirn@...e.de,
        linux-kernel@...r.kernel.org, martin.petersen@...cle.com,
        stable@...r.kernel.org
Subject: Re: [PATCH 3.16 20/63] scsi: sg: allocate with __GFP_ZERO in sg_build_indirect()

> 3.16.58-rc1 review patch.  If anyone has any objections, please let me  
> know.

> ------------------

> From: Alexander Potapenko <glider@...gle.com>

> commit a45b599ad808c3c982fdcdc12b0b8611c2f92824 upstream.

> This shall help avoid copying uninitialized memory to the userspace when
> calling ioctl(fd, SG_IO) with an empty command.

> Reported-by: syzbot+7d26fc1eea198488deab@...kaller.appspotmail.com
> Signed-off-by: Alexander Potapenko <glider@...gle.com>
> Acked-by: Douglas Gilbert <dgilbert@...erlog.com>
> Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>
> Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
>   drivers/scsi/sg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -1825,7 +1825,7 @@ retry:
>   		num = (rem_sz > scatter_elem_sz_prev) ?
>   			scatter_elem_sz_prev : rem_sz;

> -		schp->pages[k] = alloc_pages(gfp_mask, order);
> +		schp->pages[k] = alloc_pages(gfp_mask | __GFP_ZERO, order);
>   		if (!schp->pages[k])
>   			goto out;



Can't find the corresponding bug.