linux-kernel - Re: [PATCH] audit: fixed a braces coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 22 Sep 2018 16:21:43 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     glebocki.przemyslaw@...il.com
Cc:     linux-audit@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: fixed a braces coding style issue

On Fri, Sep 21, 2018 at 7:38 PM Przemysław Głębocki
<glebocki.przemyslaw@...il.com> wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Przemysław Głębocki <glebocki.przemyslaw@...il.com>
> ---
>  kernel/audit_tree.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

I generally dislike accepting coding style patches from people who
haven't made any significant code contributions.  Would you be
interested in participating in upstream audit development?  We have a
number of open issues that you could take a look at if you are
interested ...

* https://github.com/linux-audit/audit-kernel/issues

> diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
> index ea43181cde4a..3d0e45fa765d 100644
> --- a/kernel/audit_tree.c
> +++ b/kernel/audit_tree.c
> @@ -112,10 +112,9 @@ static void free_chunk(struct audit_chunk *chunk)
>  {
>         int i;
>
> -       for (i = 0; i < chunk->count; i++) {
> +       for (i = 0; i < chunk->count; i++)
>                 if (chunk->owners[i].owner)
>                         put_tree(chunk->owners[i].owner);
> -       }
>         kfree(chunk);
>  }
>
> --
> 2.17.1
>


-- 
paul moore
www.paul-moore.com