linux-kernel - Re: [PATCH TRIVIAL] Punctuation fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72m_X1U+NVf1VQuUcCi9-dERrCG3Y3tueRGbOpPd5u+a0g@mail.gmail.com>
Date:   Sun, 23 Sep 2018 02:58:56 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Diego Viola <diego.viola@...il.com>
Cc:     Jonathan Corbet <corbet@....net>,
        linux-kernel <linux-kernel@...r.kernel.org>, trivial@...nel.org
Subject: Re: [PATCH TRIVIAL] Punctuation fixes

Hi Diego,

A few things, since it looks like this is your first patch.

On Sat, Sep 22, 2018 at 5:56 PM, Diego Viola <diego.viola@...il.com> wrote:
> On Wed, Sep 12, 2018 at 12:54 AM Diego Viola <diego.viola@...il.com> wrote:
>>
>> Signed-off-by: Diego Viola <diego.viola@...il.com>
>> ---
>>  CREDITS     | 2 +-
>>  MAINTAINERS | 2 +-
>>  Makefile    | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/CREDITS b/CREDITS
>> index 5befd2d71..b82efb36d 100644
>> --- a/CREDITS
>> +++ b/CREDITS
>> @@ -1473,7 +1473,7 @@ W: http://www.linux-ide.org/
>>  W: http://www.linuxdiskcert.org/
>>  D: Random SMP kernel hacker...
>>  D: Uniform Multi-Platform E-IDE driver
>> -D: Active-ATA-Chipset maddness..........
>> +D: Active-ATA-Chipset maddness...

I think the extra dots is what was intended here :)

>>  D: Ultra DMA 133/100/66/33 w/48-bit Addressing
>>  D: ATA-Disconnect, ATA-TCQ
>>  D: ATA-Smart Kernel Daemon
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d870cb57c..6567bf245 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -93,7 +93,7 @@ Descriptions of section entries:
>>            Supported:   Someone is actually paid to look after this.
>>            Maintained:  Someone actually looks after it.
>>            Odd Fixes:   It has a maintainer but they don't have time to do
>> -                       much other than throw the odd patch in. See below..
>> +                       much other than throw the odd patch in. See below.
>>            Orphan:      No current maintainer [but maybe you could take the
>>                         role as you write your new code].
>>            Obsolete:    Old code. Something tagged obsolete generally means
>> diff --git a/Makefile b/Makefile
>> index 4d5c883a9..7b5c5d634 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1109,7 +1109,7 @@ archprepare: archheaders archscripts prepare1 scripts_basic
>>  prepare0: archprepare gcc-plugins
>>         $(Q)$(MAKE) $(build)=.
>>
>> -# All the preparing..
>> +# All the preparing...
>>  prepare: prepare0 prepare-objtool
>>
>>  # Support for using generic headers in asm-generic
>> --
>> 2.19.0
>>
>
> Jonathan,
>
> can you please merge my patch? After you merge this one, I'll go
> through the rest of the documentation to make it more consistent.

Jonathan is not responsible for these files. Jiri Kosina is the
maintainer of the trivial tree.

There are 1700+ instances of a "two-stops ellipsis" in the kernel. I
am not sure they were mistakes, given their prevalence, even if they are
not formal/common English. Also, I am not sure a commit for each 3 is
really appropriate! :) Maybe do the full sweep of the Documentation
ones in a single patch?

Also, typically you would note in the subject that this is a "v2" of
your previous patch (if I am not wrong, you sent a first version
fixing only one of the 3 mistakes).

Thanks for your first patch!

Cheers,
Miguel