linux-kernel - Re: [PATCH v2 2/2] mm/page_alloc: Add KBUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180924142609.GD18685@dhcp22.suse.cz>
Date:   Mon, 24 Sep 2018 16:26:09 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     zhe.he@...driver.com
Cc:     akpm@...ux-foundation.org, vbabka@...e.cz,
        pasha.tatashin@...cle.com, mgorman@...hsingularity.net,
        aaron.lu@...el.com, osalvador@...e.de, iamjoonsoo.kim@....com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] mm/page_alloc: Add KBUILD_MODNAME

On Sat 22-09-18 22:53:33, zhe.he@...driver.com wrote:
> From: He Zhe <zhe.he@...driver.com>
> 
> Add KBUILD_MODNAME to make prints more clear.

Please be more explicit. Examples of before and after would be really
helpful.

> Signed-off-by: He Zhe <zhe.he@...driver.com>
> Cc: akpm@...ux-foundation.org
> Cc: mhocko@...e.com
> Cc: vbabka@...e.cz
> Cc: pasha.tatashin@...cle.com
> Cc: mgorman@...hsingularity.net
> Cc: aaron.lu@...el.com
> Cc: osalvador@...e.de
> Cc: iamjoonsoo.kim@....com
> ---
> v2:
> Split the addition of KBUILD_MODNAME out
> 
>  mm/page_alloc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index f34cae1..ead9556 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -14,6 +14,8 @@
>   *          (lots of bits borrowed from Ingo Molnar & Andrew Morton)
>   */
>  
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
>  #include <linux/stddef.h>
>  #include <linux/mm.h>
>  #include <linux/swap.h>
> -- 
> 2.7.4
> 

-- 
Michal Hocko
SUSE Labs