linux-kernel - Re: [PATCH] staging: greybus: control.c: fixed some coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180924091321.GG5101@localhost>
Date:   Mon, 24 Sep 2018 11:13:21 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Aaron Williams <zero@...oaptitude.com>
Cc:     johan@...nel.org, elder@...nel.org, gregkh@...uxfoundation.org,
        greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: control.c: fixed some coding style
 issues

On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote:
> fixed some "Alignment should match open parenthesis" checks.

Note that this is not something that is mandated by the kernel coding
style, but rather a preference of the authors of checkpatch (and the
check is only enabled when the --strict option is given or when
checkpatch is run on net and staging code).

As the author and maintainer of this particular code, I do not think
this patch should be applied, but Greg may have a different opinion on
this as the overall staging maintainer.

> Signing up for the kernel clean up crew while I learn C

I would strongly suggest learning C *before* moving on to do kernel
work. 

Thanks,
Johan