linux-kernel - Re: [PATCH v2 2/2] Bluetooth: btqcomsmd: Get the BD address with device_get_bd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vet111D7SYZ4+NqcR-dr1En6R=0N7xDKM58Sms1Xh=Anw@mail.gmail.com>
Date:   Mon, 24 Sep 2018 23:47:22 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Sinan Kaya <okaya@...eaurora.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-bluetooth@...r.kernel.org, bgodavar@...eaurora.org,
        Loic Poulain <loic.poulain@...aro.org>,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH v2 2/2] Bluetooth: btqcomsmd: Get the BD address with device_get_bd_address()

On Mon, Sep 24, 2018 at 10:37 PM Matthias Kaehlcke <mka@...omium.org> wrote:
>
> Use the new API to get the BD address instead of reading it directly
> from the device tree.
>
> Also remove an unncessary pair of braces in the same area of code.
>

This looks nice!

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
> Changes in v2:
> - pass bdaddr_t instead of byte pointer + len
> ---
>  drivers/bluetooth/btqcomsmd.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c
> index 7df3eed1ef5e..ff74d2c46991 100644
> --- a/drivers/bluetooth/btqcomsmd.c
> +++ b/drivers/bluetooth/btqcomsmd.c
> @@ -172,11 +172,9 @@ static int btqcomsmd_probe(struct platform_device *pdev)
>         /* The local-bd-address property is usually injected by the
>          * bootloader which has access to the allocated BD address.
>          */
> -       if (!of_property_read_u8_array(pdev->dev.of_node, "local-bd-address",
> -                                      (u8 *)&btq->bdaddr, sizeof(bdaddr_t))) {
> +       if (!device_get_bd_address(&pdev->dev, &btq->bdaddr))
>                 dev_info(&pdev->dev, "BD address %pMR retrieved from device-tree",
>                          &btq->bdaddr);
> -       }
>
>         hdev = hci_alloc_dev();
>         if (!hdev)
> --
> 2.19.0.444.g18242da7ef-goog
>


-- 
With Best Regards,
Andy Shevchenko