linux-kernel - Re: [PATCH 1/4] sparc: Move __IGNORE* entries to non uapi header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a0_omFwid2NZzs_T=A_TY9ddfGOsVKV2vtiaVodWswbmQ@mail.gmail.com>
Date:   Mon, 24 Sep 2018 23:06:25 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Firoz Khan <firoz.khan@...aro.org>
Cc:     David Miller <davem@...emloft.net>,
        sparclinux <sparclinux@...r.kernel.org>,
        gregkh <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH 1/4] sparc: Move __IGNORE* entries to non uapi header

On Tue, Sep 18, 2018 at 1:53 PM Firoz Khan <firoz.khan@...aro.org> wrote:
>
> On 6 September 2018 at 20:58, Arnd Bergmann <arnd@...db.de> wrote:
> > On Tue, Sep 4, 2018 at 6:42 AM Firoz Khan <firoz.khan@...aro.org> wrote:
> >
> >> +++ b/arch/sparc/include/uapi/asm/unistd.h
> >> @@ -15,12 +15,6 @@
> >>  #ifndef _UAPI_SPARC_UNISTD_H
> >>  #define _UAPI_SPARC_UNISTD_H
> >>
> >> -#ifndef __32bit_syscall_numbers__
> >> -#ifndef __arch64__
> >> -#define __32bit_syscall_numbers__
> >> -#endif
> >> -#endif
> >
> > This is certainly required in the uapi header as of this patch,
> > without it all the numbers are wrong when you include the
> > file from user space.
> >
> > I suppose it can be removed later once the header is replaced
> > with the two generated versions,
>
> The script will generate 2 versions, ie, unistd_32.h and unistd_64.h.
> Please give few more pointer here.

You still need to check at least for __arch64__ in asm/unistd.h in order
to pick which header to include, right? Since the
__32bit_syscall_numbers__ check was already in the public header
file, it may also be possible that there is some user space application
that sets this in order to get the 32-bit definitions. This might e.g.
be needed for strace.

     Arnd