linux-kernel - Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3da76eb-7d17-40ba-a98d-c4a743240785@cesnet.cz>
Date:   Mon, 24 Sep 2018 12:02:33 +0200
From:   Jan Kundrát <jan.kundrat@...net.cz>
To:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>
Cc:     Baruch Siach <baruch@...s.co.il>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Jason Cooper <jason@...edaemon.net>,
        <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

>>> What about something like the below. I tested it, including the error
>>> case by forcing an -EPROBE_DEFER. The new pci_unmap_io() is modeled
>>> after pci_unmap_iospace(). Actually, I would prefer to use
>>> pci_remap_iospace() and pci_unmap_iospace() but for now this API
>>> doesn't allow overloading the memory type used for the mapping.  
>> 
>> Thanks for providing this fix so quickly, Thomas. I can confirm that this 
>> patch -- tested on top of 
>> 54eda9df17f3215b9ed16629ee71ea07413efdaf ("Merge 
>> tag 'pci-v4.19-fixes-1' of 
>> git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci"). 
>> Disclaimer: I 
>> have zero familiarity with Linux' PCI code.
>> 
>> Tested-by: Jan Kundrát <jan.kundrat@...net.cz>
>
> Thanks for the testing. I'll wait for Russell to say if he is happy
> (or not) with the addition of pci_unmap_io() in the ARM code, if that's
> the case, I'll send a proper patch to fix the issue.

Hi Thomas, Russell,
is there a proper patch for this? I've just verified that 4.19-rc5 won't 
boot for me either. Thomas' quick patch applies and makes the problem go 
away.

With kind regards,
Jan