linux-kernel - Re: [PATCH AUTOSEL 4.9 30/34] dmaengine: hsu: Support dmaengine_terminate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Sep 2018 00:55:18 +0000
From:   Sasha Levin <Alexander.Levin@...rosoft.com>
To:     Vinod <vkoul@...nel.org>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH AUTOSEL 4.9 30/34] dmaengine: hsu: Support
 dmaengine_terminate_sync()

On Wed, Sep 19, 2018 at 05:38:51PM -0700, Vinod wrote:
>On 15-09-18, 01:34, Sasha Levin wrote:
>> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>
>> [ Upstream commit 2abc66cd499aa16876e45c6438788902f7d1ce22 ]
>>
>> It appears that the driver misses the support of dmaengine_terminate_sync().
>> Since many of callers expects this behaviour implement the new
>> device_synchronize() callback to allow proper synchronization when stopping
>> a channel.
>
>This adds missing support for an optional call, but I am not aware of
>any reports of breakage due to missing this patch. Do you want to carry
>this for stable?

I guess that using the word "expect" in the commit log suggested to me
that this wasn't optional.

I'll drop it, thanks!