linux-kernel - RE: [PATCH v2 3/5] drivers: clk-qoriq: Add clockgen support for lx2160a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR04MB4800CA1AFEB6EB7B56680CBBF3170@VI1PR04MB4800.eurprd04.prod.outlook.com>
Date:   Mon, 24 Sep 2018 11:56:08 +0000
From:   Vabhav Sharma <vabhav.sharma@....com>
To:     Scott Wood <oss@...error.net>,
        "sudeep.holla@....com" <sudeep.holla@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel-owner@...r.kernel.org" 
        <linux-kernel-owner@...r.kernel.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "yamada.masahiro@...ionext.com" <yamada.masahiro@...ionext.com>
CC:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        Yogesh Narayan Gaur <yogeshnarayan.gaur@....com>,
        Andy Tang <andy.tang@....com>
Subject: RE: [PATCH v2 3/5] drivers: clk-qoriq: Add clockgen support for
 lx2160a



> -----Original Message-----
> From: Scott Wood <oss@...error.net>
> Sent: Sunday, September 16, 2018 12:54 AM
> To: Vabhav Sharma <vabhav.sharma@....com>; sudeep.holla@....com; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org; robh+dt@...nel.org;
> mark.rutland@....com; linuxppc-dev@...ts.ozlabs.org; linux-arm-
> kernel@...ts.infradead.org; mturquette@...libre.com; sboyd@...nel.org;
> rjw@...ysocki.net; viresh.kumar@...aro.org; linux-clk@...r.kernel.org; linux-
> pm@...r.kernel.org; linux-kernel-owner@...r.kernel.org;
> catalin.marinas@....com; will.deacon@....com;
> gregkh@...uxfoundation.org; arnd@...db.de; kstewart@...uxfoundation.org;
> yamada.masahiro@...ionext.com
> Cc: linux@...linux.org.uk; Varun Sethi <V.Sethi@....com>; Udit Kumar
> <udit.kumar@....com>; Yogesh Narayan Gaur
> <yogeshnarayan.gaur@....com>; Andy Tang <andy.tang@....com>
> Subject: Re: [PATCH v2 3/5] drivers: clk-qoriq: Add clockgen support for lx2160a
> 
> On Fri, 2018-09-14 at 02:07 +0530, Vabhav Sharma wrote:
> > From: Yogesh Gaur <yogeshnarayan.gaur@....com>
> >
> > Add clockgen support for lx2160a.
> > Added entry for compat 'fsl,lx2160a-clockgen'.
> >
> > Signed-off-by: Tang Yuantian <andy.tang@....com>
> > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@....com>
> > Signed-off-by: Vabhav Sharma <vabhav.sharma@....com>
> > Acked-by: Stephen Boyd <sboyd@...nel.org>
> > ---
> >  drivers/clk/clk-qoriq.c         | 14 +++++++++++++-
> >  drivers/cpufreq/qoriq-cpufreq.c |  1 +
> >  2 files changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > 3a1812f..e9ae70b 100644
> > --- a/drivers/clk/clk-qoriq.c
> > +++ b/drivers/clk/clk-qoriq.c
> > @@ -79,7 +79,7 @@ struct clockgen_chipinfo {
> >  	const struct clockgen_muxinfo *cmux_groups[2];
> >  	const struct clockgen_muxinfo *hwaccel[NUM_HWACCEL];
> >  	void (*init_periph)(struct clockgen *cg);
> > -	int cmux_to_group[NUM_CMUX]; /* -1 terminates if fewer than
> > NUM_CMUX */
> > +	int cmux_to_group[NUM_CMUX+1]; /* -1 terminate if fewer to
> > NUM_CMUX+1 */
> 
> You need to add the -1 terminator to p4080, and remove the "if fewer"
> comment since the whole point of this is that every array gets -1 terminated.
Ok, Updated
> 
> Why did you change "terminates" to "terminate" and "than" to "to"?
> 
> This +1 change should be a separate patch from lx2160a support.
Sure, Sending as separate patch
> 
> -Scott