linux-kernel - Re: [PATCH] usb: dwc2: remove set but unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Sep 2018 05:48:33 +0000
From:   Minas Harutyunyan <minas.harutyunyan@...opsys.com>
To:     Josh Abraham <j.abraham1776@...il.com>,
        "minas.harutyunyan@...opsys.com" <minas.harutyunyan@...opsys.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc2: remove set but unused variable

On 9/24/2018 5:41 AM, Josh Abraham wrote:
> This patch removes a set but unused variable in hcd.c.
> 
> Fixes gcc warning:
> variable ‘data_fifo’ set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Joshua Abraham <j.abraham1776@...il.com>
> ---
>   drivers/usb/dwc2/hcd.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2bd6e6bfc241..5f23b933cafc 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -1328,14 +1328,11 @@ static void dwc2_hc_write_packet(struct dwc2_hsotg *hsotg,
>   	u32 remaining_count;
>   	u32 byte_count;
>   	u32 dword_count;
> -	u32 __iomem *data_fifo;
>   	u32 *data_buf = (u32 *)chan->xfer_buf;
>   
>   	if (dbg_hc(chan))
>   		dev_vdbg(hsotg->dev, "%s()\n", __func__);
>   
> -	data_fifo = (u32 __iomem *)(hsotg->regs + HCFIFO(chan->hc_num));
> -
>   	remaining_count = chan->xfer_len - chan->xfer_count;
>   	if (remaining_count > chan->max_packet)
>   		byte_count = chan->max_packet;
> 
Acked-by: Minas Harutyunyan <hminas@...opsys.com>