linux-kernel - Re: [PATCH] Revert "uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Sep 2018 14:08:13 +0200
From:   Lubomir Rintel <lkundrak@...sk>
To:     David Howells <dhowells@...hat.com>
Cc:     keyrings@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        stable@...r.kernel.org
Subject: Re: [PATCH] Revert "uapi/linux/keyctl.h: don't use C++ reserved
 keyword as a struct member name"

On Mon, 2018-09-24 at 13:00 +0100, David Howells wrote:
> Lubomir Rintel <lkundrak@...sk> wrote:
> 
> > This changes UAPI, breaking iwd and libell:
> > 
> >   ell/key.c: In function 'kernel_dh_compute':
> >   ell/key.c:205:38: error: 'struct keyctl_dh_params' has no member
> > named 'private'; did you mean 'dh_private'?
> >     struct keyctl_dh_params params = { .private = private,
> >                                         ^~~~~~~
> >                                         dh_private
> > 
> > This reverts commit 8a2336e549d385bb0b46880435b411df8d8200e8.
> > 
> > Cc: David Howells <dhowells@...hat.com>
> > Cc: James Morris <jmorris@...ei.org>
> > Cc: "Serge E. Hallyn" <serge@...lyn.com>
> > Cc: Mat Martineau <mathew.j.martineau@...ux.intel.com>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> > Cc: <stable@...r.kernel.org>
> 
> Can I stick your Signed-off-by on it?

   1. Yes, please do.

Signed-off-by: Lubomir Rintel <lkundrak@...sk>

> 
> David