linux-kernel - Re: [PATCH] PCI: remove unnecessary check of device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Sep 2018 08:20:46 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>,
        Michal Simek <michal.simek@...inx.com>
CC:     <linux-kernel@...r.kernel.org>, Will Deacon <will.deacon@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Alan Douglas <adouglas@...ence.com>,
        Subrahmanya Lingappa <l.subrahmanya@...iveil.co.in>,
        <linux-pci@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] PCI: remove unnecessary check of device_type == pci

Hi Lorenzo,

On 21.9.2018 11:29, Lorenzo Pieralisi wrote:
> On Wed, Aug 29, 2018 at 01:34:40PM -0500, Rob Herring wrote:
>> PCI host drivers have already matched on compatible strings, so checking
>> device_type is redundant. Also, device_type is considered deprecated for
>> FDT though we've still been requiring it for PCI hosts as it is useful
>> for finding PCI buses.
>>
>> Cc: Will Deacon <will.deacon@....com>
>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
>> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
>> Cc: Alan Douglas <adouglas@...ence.com>
>> Cc: Subrahmanya Lingappa <l.subrahmanya@...iveil.co.in>
>> Cc: Michal Simek <michal.simek@...inx.com>
>> Cc: linux-pci@...r.kernel.org
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> ---
>>  drivers/pci/controller/pci-host-common.c   | 8 --------
>>  drivers/pci/controller/pcie-cadence-host.c | 7 -------
>>  drivers/pci/controller/pcie-mobiveil.c     | 7 -------
>>  drivers/pci/controller/pcie-xilinx-nwl.c   | 9 ---------
>>  drivers/pci/controller/pcie-xilinx.c       | 7 -------
>>  5 files changed, 38 deletions(-)
> 
> Hi Michal,
> 
> are you OK with these changes ?


This change is fine.
Acked-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal