linux-kernel - Re: [PATCH] xhci: Add check for invalid byte size error when UAS devices are connected.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ccf6cbc-cdf6-c6f0-486d-b971837d1c8a@amd.com>
Date:   Tue, 25 Sep 2018 14:44:42 +0530
From:   Sandeep Singh <ssingh1@....com>
To:     Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Sandeep Singh <Sandeep.Singh@....com>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        gregkh@...uxfoundation.org, mathias.nyman@...el.com
Cc:     Nehal Shah <Nehal-bakulchandra.Shah@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>
Subject: Re: [PATCH] xhci: Add check for invalid byte size error when UAS
 devices are connected.



On 9/24/2018 6:39 PM, Mathias Nyman wrote:
> On 21.09.2018 16:22, Sandeep Singh wrote:
>> From: Sandeep Singh <sandeep.singh@....com>
>>
>> Observed "TRB completion code (27)" error which corresponds to Stopped -
>> Length Invalid error(xhci spec section 4.17.4) while connecting USB to
>> SATA bridge.
>>
>> Looks like this case was not considered when the following patch[1] was
>> committed. Hence adding this new check which can prevent
>> the invalid byte size error.
>>
>> [1] ade2e3a xhci: handle transfer events without TRB pointer
>>
> 
> Thanks, adding to queue.
> 
> Just out of curiosity, was the TRB pointer bits all zeroes
> in this  Stopped -Length invalid transfer event TRB?
>
Yes, TRB pointer bits all zeroes

> -Mathias
> 
Thanks
Sandeep