lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Sep 2018 11:58:23 +0200 From: Boris Brezillon <boris.brezillon@...tlin.com> To: Geert Uytterhoeven <geert+renesas@...der.be> Cc: Mark Brown <broonie@...nel.org>, David Woodhouse <dwmw2@...radead.org>, Brian Norris <computersforpeace@...il.com>, Marek Vasut <marek.vasut@...il.com>, Richard Weinberger <richard@....at>, linux-spi@...r.kernel.org, linux-mtd@...ts.infradead.org, linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] spi: spi-mem: Fix inverted logic in op sanity check On Tue, 25 Sep 2018 11:46:55 +0200 Geert Uytterhoeven <geert+renesas@...der.be> wrote: > On r8a7791/koelsch: > > m25p80 spi0.0: error -22 reading 9f > m25p80: probe of spi0.0 failed with error -22 > > Apparently the logic in spi_mem_check_op() is wrong, rejecting the > spi-mem operation if any buswidth is valid, instead of invalid. > > Fixes: 380583227c0c7f52 ("spi: spi-mem: Add extra sanity checks on the op param") > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be> Reviewed-by: Boris Brezillon <boris.brezillon@...tlin.com> Sorry for the mess :-/, and thanks for reporting/fixing it. > --- > drivers/spi/spi-mem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c > index cc3d425aae56c634..62a7b80801d22098 100644 > --- a/drivers/spi/spi-mem.c > +++ b/drivers/spi/spi-mem.c > @@ -169,10 +169,10 @@ static int spi_mem_check_op(const struct spi_mem_op *op) > (op->data.nbytes && !op->data.buswidth)) > return -EINVAL; > > - if (spi_mem_buswidth_is_valid(op->cmd.buswidth) || > - spi_mem_buswidth_is_valid(op->addr.buswidth) || > - spi_mem_buswidth_is_valid(op->dummy.buswidth) || > - spi_mem_buswidth_is_valid(op->data.buswidth)) > + if (!spi_mem_buswidth_is_valid(op->cmd.buswidth) || > + !spi_mem_buswidth_is_valid(op->addr.buswidth) || > + !spi_mem_buswidth_is_valid(op->dummy.buswidth) || > + !spi_mem_buswidth_is_valid(op->data.buswidth)) > return -EINVAL; > > return 0;
Powered by blists - more mailing lists