linux-kernel - Re: [PATCH v4 20/21] tpm1: reimplement tpm1_continue_selftest() using tpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca7221f592cfcdc312fe1ec72623f118dfa21788.camel@linux.intel.com>
Date:   Tue, 25 Sep 2018 17:25:40 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Nayna Jain <nayna@...ux.vnet.ibm.com>,
        Tomas Winkler <tomas.winkler@...el.com>,
        Jason Gunthorpe <jgg@...pe.ca>
Cc:     Alexander Usyskin <alexander.usyskin@...el.com>,
        Tadeusz Struk <tadeusz.struk@...el.com>,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 20/21] tpm1: reimplement tpm1_continue_selftest()
 using tpm_buf

On Tue, 2018-09-25 at 15:53 +0530, Nayna Jain wrote:
> > +
> > +	rc = tpm_transmit_cmd(chip, NULL, &buf.data, PAGE_SIZE,
> 
> I think this needs to buf.data instead of &buf.data
> 
> Thanks & Regards,
>       - Nayna

You are absolutely right. Thank you.

/Jarkko