linux-kernel - Re: [PATCH 3/5] lib: Add umoddi3 and udivmoddi4 of GCC library routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180925152508.GA24002@infradead.org>
Date:   Tue, 25 Sep 2018 08:25:08 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Zong Li <zongbox@...il.com>
Cc:     hch@...radead.org, palmer@...ive.com, aou@...s.berkeley.edu,
        vincentc@...estech.com, zong@...estech.com,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] lib: Add umoddi3 and udivmoddi4 of GCC library
 routines

On Tue, Sep 25, 2018 at 10:19:55AM +0800, Zong Li wrote:
> The RV32 need the umoddi3 to do modulo when the operands are long long
> type, like other libraries implementation such as ucmpdi2, lshrdi3 and
> so on. I encounter the undefined reference 'umoddi3' when I use the in
> house dma driver, although it is in house driver, but I think that
> umoddi3 is a common function for RV32. The udivmoddi4 and umoddi3 are
> copies from libgcc in gcc. There are other functions use the
> udivmoddi4 in libgcc, so I separate the umoddi3 and udivmoddi4 for
> flexible extension in the future.

I don't think libgcc is GPLv2 licensed, is it?  Also please retain
the copyright notices from libgcc.