linux-kernel - Re: [PATCH] staging: dgnc: Fix Kconfig help header and text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5bb4ab0-42f6-3fd1-006d-670a355e8702@infradead.org>
Date:   Tue, 25 Sep 2018 08:34:43 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     sehro rautenkranz <sehro@...ro.org>, lidza-louina@...il.com
Cc:     markh@...pro.net, driverdev-devel@...uxdriverproject.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: dgnc: Fix Kconfig help header and text

On 9/24/18 11:20 PM, sehro rautenkranz wrote:
> Replace Kconfig help header and text to match other modules. Issue found
> by checkpatch.
> 
> Signed-off-by: sehro rautenkranz <sehro@...ro.org>
> ---

Hi,

Documentation/process/coding-style.rst says:

Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.


>  drivers/staging/dgnc/Kconfig | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/Kconfig b/drivers/staging/dgnc/Kconfig
> index 032c2a795238..c845b357b53d 100644
> --- a/drivers/staging/dgnc/Kconfig
> +++ b/drivers/staging/dgnc/Kconfig
> @@ -2,5 +2,9 @@ config DGNC
>         tristate "Digi Neo and Classic PCI Products"
>         default n
>         depends on TTY && PCI
> -       ---help---
> -       Driver for the Digi International Neo and Classic PCI based product line.
> +       help
> +            Say Y here to enable support for the Digi International Neo and
> +            Classic PCI based product line.
> +
> +            To compile this driver as a module, say M here: the module will be
> +            called dgnc
> 

thanks,
-- 
~Randy