linux-kernel - Re: [PATCH crypto-next 00/23] crypto: skcipher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJGYJ_ePK+7pfWgjpLN2cQQ57fcE5P-k2p8MXX_SnmLnQ@mail.gmail.com>
Date:   Tue, 25 Sep 2018 08:39:10 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Eric Biggers <ebiggers@...gle.com>,
        linux-crypto <linux-crypto@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH crypto-next 00/23] crypto: skcipher - Remove VLA usage

On Mon, Sep 24, 2018 at 9:49 PM, Herbert Xu <herbert@...dor.apana.org.au> wrote:
> On Mon, Sep 24, 2018 at 05:49:37PM -0700, Kees Cook wrote:
>>
>> > Kees Cook (23):
>> >   crypto: skcipher - Introduce crypto_sync_skcipher
>> >   gss_krb5: Remove VLA usage of skcipher
>> >   lib80211: Remove VLA usage of skcipher
>> >   mac802154: Remove VLA usage of skcipher
>> >   s390/crypto: Remove VLA usage of skcipher
>> >   x86/fpu: Remove VLA usage of skcipher
>> >   block: cryptoloop: Remove VLA usage of skcipher
>> >   libceph: Remove VLA usage of skcipher
>> >   ppp: mppe: Remove VLA usage of skcipher
>> >   rxrpc: Remove VLA usage of skcipher
>> >   wusb: Remove VLA usage of skcipher
>> >   crypto: ccp - Remove VLA usage of skcipher
>> >   crypto: vmx - Remove VLA usage of skcipher
>> >   crypto: null - Remove VLA usage of skcipher
>> >   crypto: cryptd - Remove VLA usage of skcipher
>> >   crypto: sahara - Remove VLA usage of skcipher
>> >   crypto: qce - Remove VLA usage of skcipher
>> >   crypto: artpec6 - Remove VLA usage of skcipher
>> >   crypto: chelsio - Remove VLA usage of skcipher
>> >   crypto: mxs-dcp - Remove VLA usage of skcipher
>> >   crypto: omap-aes - Remove VLA usage of skcipher
>> >   crypto: picoxcell - Remove VLA usage of skcipher
>> >   crypto: skcipher - Remove SKCIPHER_REQUEST_ON_STACK()
>>
>> How do these look to you, Herbert? I'd really like to make sure these
>> make it for the next merge window -- they're the last VLAs left in the
>> kernel now. :)
>
> I have no problems with the crypto parts.  Do we have acks for
> all of the others?

Some have trickled in (wusb, lib80211), along with some Reviewed-bys
from Ard. I was hoping that since it was a wrapper-only change there
wouldn't be a need to block on waiting for Acks.

Thanks for looking at it; I'm excited to finally be done with VLA removals. :)

-Kees

-- 
Kees Cook
Pixel Security