linux-kernel - Re: [PATCH V2] mm/hugetlb: Add mmap() encodings for 32MB and 512MB page sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f395fc79-4a64-8534-cd31-7a36bfb50cd1@oracle.com>
Date:   Tue, 25 Sep 2018 09:39:34 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org
Cc:     mhocko@...nel.org, punit.agrawal@....com, will.deacon@....com,
        akpm@...ux-foundation.org
Subject: Re: [PATCH V2] mm/hugetlb: Add mmap() encodings for 32MB and 512MB
 page sizes

On 9/24/18 7:08 PM, Anshuman Khandual wrote:
> ARM64 architecture also supports 32MB and 512MB HugeTLB page sizes.
> This just adds mmap() system call argument encoding for them.
> 
> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
> ---
> 
> Changes in V2:
> - Updated SHM and MFD definitions per Mike

Thanks Anshuman,

Acked-by: Mike Kravetz <mike.kravetz@...cle.com>

-- 
Mike Kravetz

> 
>  include/uapi/asm-generic/hugetlb_encode.h | 2 ++
>  include/uapi/linux/memfd.h                | 2 ++
>  include/uapi/linux/mman.h                 | 2 ++
>  include/uapi/linux/shm.h                  | 2 ++
>  4 files changed, 8 insertions(+)
> 
> diff --git a/include/uapi/asm-generic/hugetlb_encode.h b/include/uapi/asm-generic/hugetlb_encode.h
> index e4732d3..b0f8e87 100644
> --- a/include/uapi/asm-generic/hugetlb_encode.h
> +++ b/include/uapi/asm-generic/hugetlb_encode.h
> @@ -26,7 +26,9 @@
>  #define HUGETLB_FLAG_ENCODE_2MB		(21 << HUGETLB_FLAG_ENCODE_SHIFT)
>  #define HUGETLB_FLAG_ENCODE_8MB		(23 << HUGETLB_FLAG_ENCODE_SHIFT)
>  #define HUGETLB_FLAG_ENCODE_16MB	(24 << HUGETLB_FLAG_ENCODE_SHIFT)
> +#define HUGETLB_FLAG_ENCODE_32MB	(25 << HUGETLB_FLAG_ENCODE_SHIFT)
>  #define HUGETLB_FLAG_ENCODE_256MB	(28 << HUGETLB_FLAG_ENCODE_SHIFT)
> +#define HUGETLB_FLAG_ENCODE_512MB	(29 << HUGETLB_FLAG_ENCODE_SHIFT)
>  #define HUGETLB_FLAG_ENCODE_1GB		(30 << HUGETLB_FLAG_ENCODE_SHIFT)
>  #define HUGETLB_FLAG_ENCODE_2GB		(31 << HUGETLB_FLAG_ENCODE_SHIFT)
>  #define HUGETLB_FLAG_ENCODE_16GB	(34 << HUGETLB_FLAG_ENCODE_SHIFT)
> diff --git a/include/uapi/linux/memfd.h b/include/uapi/linux/memfd.h
> index 015a4c0..7a8a267 100644
> --- a/include/uapi/linux/memfd.h
> +++ b/include/uapi/linux/memfd.h
> @@ -25,7 +25,9 @@
>  #define MFD_HUGE_2MB	HUGETLB_FLAG_ENCODE_2MB
>  #define MFD_HUGE_8MB	HUGETLB_FLAG_ENCODE_8MB
>  #define MFD_HUGE_16MB	HUGETLB_FLAG_ENCODE_16MB
> +#define MFD_HUGE_32MB	HUGETLB_FLAG_ENCODE_32MB
>  #define MFD_HUGE_256MB	HUGETLB_FLAG_ENCODE_256MB
> +#define MFD_HUGE_512MB	HUGETLB_FLAG_ENCODE_512MB
>  #define MFD_HUGE_1GB	HUGETLB_FLAG_ENCODE_1GB
>  #define MFD_HUGE_2GB	HUGETLB_FLAG_ENCODE_2GB
>  #define MFD_HUGE_16GB	HUGETLB_FLAG_ENCODE_16GB
> diff --git a/include/uapi/linux/mman.h b/include/uapi/linux/mman.h
> index bfd5938..d0f515d 100644
> --- a/include/uapi/linux/mman.h
> +++ b/include/uapi/linux/mman.h
> @@ -28,7 +28,9 @@
>  #define MAP_HUGE_2MB	HUGETLB_FLAG_ENCODE_2MB
>  #define MAP_HUGE_8MB	HUGETLB_FLAG_ENCODE_8MB
>  #define MAP_HUGE_16MB	HUGETLB_FLAG_ENCODE_16MB
> +#define MAP_HUGE_32MB	HUGETLB_FLAG_ENCODE_32MB
>  #define MAP_HUGE_256MB	HUGETLB_FLAG_ENCODE_256MB
> +#define MAP_HUGE_512MB	HUGETLB_FLAG_ENCODE_512MB
>  #define MAP_HUGE_1GB	HUGETLB_FLAG_ENCODE_1GB
>  #define MAP_HUGE_2GB	HUGETLB_FLAG_ENCODE_2GB
>  #define MAP_HUGE_16GB	HUGETLB_FLAG_ENCODE_16GB
> diff --git a/include/uapi/linux/shm.h b/include/uapi/linux/shm.h
> index dde1344..6507ad0 100644
> --- a/include/uapi/linux/shm.h
> +++ b/include/uapi/linux/shm.h
> @@ -65,7 +65,9 @@ struct shmid_ds {
>  #define SHM_HUGE_2MB	HUGETLB_FLAG_ENCODE_2MB
>  #define SHM_HUGE_8MB	HUGETLB_FLAG_ENCODE_8MB
>  #define SHM_HUGE_16MB	HUGETLB_FLAG_ENCODE_16MB
> +#define SHM_HUGE_32MB	HUGETLB_FLAG_ENCODE_32MB
>  #define SHM_HUGE_256MB	HUGETLB_FLAG_ENCODE_256MB
> +#define SHM_HUGE_512MB	HUGETLB_FLAG_ENCODE_512MB
>  #define SHM_HUGE_1GB	HUGETLB_FLAG_ENCODE_1GB
>  #define SHM_HUGE_2GB	HUGETLB_FLAG_ENCODE_2GB
>  #define SHM_HUGE_16GB	HUGETLB_FLAG_ENCODE_16GB
>