linux-kernel - Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180925164838.GA25852@bogus>
Date:   Tue, 25 Sep 2018 11:48:39 -0500
From:   Rob Herring <robh@...nel.org>
To:     Yinbo Zhu <yinbo.zhu@....com>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Mark Rutland <mark.rutland@....com>, xiaobo.xie@....com,
        Ran Wang <ran.wang_1@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, festevam@...il.com
Subject: Re: [PATCH v1] arm64: dts: dwc3: Add description of
 'configure-gfladj'

On Wed, Aug 29, 2018 at 03:33:24PM +0800, Yinbo Zhu wrote:
> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree

Not a complete sentence.

The subject should be: "dt-bindings: usb: ..."
> 
> Signed-off-by: Yinbo Zhu <yinbo.zhu@....com>
> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 3e4c38b..40c6568 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,7 @@ Optional properties:
>  			When just one value, which means INCRX burst mode enabled. When
>  			more than one value, which means undefined length INCR burst type
>  			enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
> + - configure-gfladj: determine whether frame length adjustment is required or not.

Needs a vendor prefix.

What's the type? bool?

What determines if this is needed. If fixed for an SoC or IP version, 
then the compatible string should imply this.

Rob