linux-kernel - duplicate check for CAP_SYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <9CFCBC36-B08F-4920-B144-F7EED5B9BC33@vt.edu>
Date:   Tue, 25 Sep 2018 13:27:05 -0400
From:   Tong Zhang <ztong@...edu>
To:     axboe@...nel.dk, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, Wenbo Shen <shenwenbosmile@...il.com>
Subject: duplicate check for CAP_SYS_RAWIO

Kernel Version: 4.18.5

Problem Description:

We found a path where duplicate capability checks are observed,
the path is :

scsi_ioctl<- require CAP_SYS_ADMIN and CAP_SYS_RAWIO
     `->sg_scsi_ioctl() 
                `->blk_verify_command() <- require CAP_SYS_RAWIO

CAP_SYS_RAWIO is checked twice.

related file: 
  block/scsi_ioctl.c:215 
  block/scsi_ioctl.c:471
  drivers/scsi/scsi_ioctl.c:240
  drivers/scsi/scsi_ioctl.c:242

- Tong