linux-kernel - Re: [PATCH v2 17/20] vmw_balloon: compaction support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180925181507.GA25458@kroah.com>
Date:   Tue, 25 Sep 2018 20:15:07 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nadav Amit <namit@...are.com>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
        Xavier Deguillard <xdeguillard@...are.com>
Subject: Re: [PATCH v2 17/20] vmw_balloon: compaction support

On Thu, Sep 20, 2018 at 10:30:23AM -0700, Nadav Amit wrote:
> --- a/include/uapi/linux/magic.h
> +++ b/include/uapi/linux/magic.h
> @@ -89,5 +89,6 @@
>  #define UDF_SUPER_MAGIC		0x15013346
>  #define BALLOON_KVM_MAGIC	0x13661366
>  #define ZSMALLOC_MAGIC		0x58295829
> +#define BALLOON_VMW_MAGIC	0xba11007

Any specific reason why you didn't put the leading 0 on your magic
number to make everything align properly?

And there is no need to put this in magic.h, nothing outside of your
code sees this value.  It is not a user api, so please do not make it
one.

thanks,

greg k-h