linux-kernel - Re: [PATCH v2 01/03] dt-bindings: clock: Add Clock Management Unit for Actions Semi S500 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Sep 2018 14:10:47 -0500
From:   Rob Herring <robh@...nel.org>
To:     Edgar Bernardi Righi <edgar.righi@...tec.org.br>
Cc:     linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        linux@...linux.org.uk,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Guilherme G. Simões 
        <guilherme.simoes@...tec.org.br>,
        Jon maddog Hall <jon.maddog.hall@...il.com>,
        mkzuffo@....usp.br,
        Andreas Färber <afaerber@...e.de>,
        sboyd@...nel.org, mark.rutland@....com, linux@...ietech.com,
        support@...ietech.com, catalin.marinas@....com,
        Michael Turquette <mturquette@...libre.com>,
        will.deacon@....com, thomas liau <thomas.liau@...ions-semi.com>,
        darren@...ietech.com, jeff.chen@...ions-semi.com, pn@...x.de,
        mp-cs@...ions-semi.com,
        Laisa Costa - LSI-TEC <laisa.costa@...tec.org.br>
Subject: Re: [PATCH v2 01/03] dt-bindings: clock: Add Clock Management Unit
 for Actions Semi S500 SoC

On Tue, Sep 04, 2018 at 12:36:36PM -0300, Edgar Bernardi Righi wrote:
> Add Clock Management Unit for Actions Semi S500 SoC. Dt-Bindings
> constants added.
> Tested on a Lemaker Guitar board.
> 
> Signed-off-by: Edgar Bernardi Righi <edgar.righi@...tec.org.br>
> 
> diff --git a/include/dt-bindings/clock/actions,s500-cmu.h
> b/include/dt-bindings/clock/actions,s500-cmu.h
> new file mode 100644
> index 000000000000..34e5849ffcf1
> --- /dev/null
> +++ b/include/dt-bindings/clock/actions,s500-cmu.h
> @@ -0,0 +1,78 @@
> +// SPDX-License-Identifier: GPL-2.0+

Headers should be /* */ style comments.

Otherwise,

Reviewed-by: Rob Herring <robh@...nel.org>

> +//
> +// Device Tree binding constants for Actions Semi S500 Clock Management Unit
> +//
> +// Copyright (c) 2014 Actions Semi Inc.
> +// Copyright (c) 2018 Linaro Ltd.
> +// Copyright (c) 2018 LSI-TEC - Caninos Loucos