[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <59f16a7e-4221-73e0-cf6e-3461717be318@infradead.org>
Date: Tue, 25 Sep 2018 12:49:18 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
sehro rautenkranz <sehro@...ro.org>
Cc: Lidza Louina <lidza.louina@...il.com>,
Mark Hounschell <markh@...pro.net>,
driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: dgnc: Fix Kconfig help header and text
On 9/25/18 11:46 AM, Greg Kroah-Hartman wrote:
> On Tue, Sep 25, 2018 at 10:22:24AM -0600, sehro rautenkranz wrote:
>> Replace Kconfig help header and text to match other modules. Issue found
>> my checkpatch.
>>
>> Spacing adjusted to match Documentation/process/coding-style.rst. Issue
>> reported by rdunlap@...radead.org. (try 2)
>
> The "try 2" needs go to below the --- line.
>
> Also, you need to properly version your patches so that I have a clue
> as to which is the "latest" one.
>
>> Signed-off-by: sehro rautenkranz <sehro@...ro.org>
>
> You forgot Randy's Reported-by.
>
> Also, properly Capitalize your name.
>
> v3?
and the help text is still not indented correctly:
use one tab + 2 spaces for help text.
--
~Randy
Powered by blists - more mailing lists