linux-kernel - Re: [PATCH 10/11] UAPI: ndctl: Remove use of PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4gmMwRAG=VxWNyeacxdsPCsaT+BtR+27+bHT=6heAZ3sQ@mail.gmail.com>
Date:   Tue, 25 Sep 2018 13:17:54 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     David Howells <dhowells@...hat.com>
Cc:     Linux API <linux-api@...r.kernel.org>,
        linux-kbuild@...r.kernel.org,
        linux-nvdimm <linux-nvdimm@...ts.01.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/11] UAPI: ndctl: Remove use of PAGE_SIZE [ver #2]

On Thu, Sep 6, 2018 at 2:19 AM David Howells <dhowells@...hat.com> wrote:
>
> The macro PAGE_SIZE isn't valid outside of the kernel, so it should not
> appear in UAPI headers.
>
> Furthermore, the actual machine page size could theoretically change from
> an application's point of view if it's running in a container that gets
> migrated to another machine (say 4K/ppc64 to 64K/ppc64).
>
> Fixes: f2ba5a5baecf ("libnvdimm, namespace: make min namespace size 4K")
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Dan Williams <dan.j.williams@...el.com>

Acked-by: Dan Williams <dan.j.williams@...el.com>

Let me know if you want me to pick this up for 4.20.