linux-kernel - [PATCH 00/13] staging:rtl8192u: Style & memory leak fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Sep 2018 20:16:51 +0100
From:   John Whitmore <johnfwhitmore@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        John Whitmore <johnfwhitmore@...il.com>
Subject: [PATCH 00/13] staging:rtl8192u: Style & memory leak fix

Back again. I previously went through the struct ht_capability_ele
renaming member variables as being unused. At the time I wasn't
100% sure that the structure wasn't memory mapped, or used by
external callers to the module, through function pointers or exported
symbols. Having had a more detailed look over the code I'm happy
that these member variables are not used and have removed them from
the code.

The last patch is a potential memory leak, which only happens if two
memory allocations succeed and the third allocation fails. So it's
probably never going to happen, but fixed it anyhow.

I've tried to find this device, or a datasheet on it, so that I
could actually make sure it still worked but that's not been possible.
Apparently it's a discontinued device, but that possibly makes it a
safer sandbox to start messing with.

John Whitmore (13):
  staging:rtl8192u: Remove HTHalfMcsToDataRate() - Style
  staging:rtl8192u: Make HTMcsToDataRate static - Style
  staging:rtl8192u: Remove definition of HTSetConnectBwMode - Style
  staging:rtl8192u: Move HTSetConnectBwModeCallback() - Style
  staging:rtl8192u: Remove AdvCoding and GreenField - Style
  staging:rtl8192u: Remove TxSTBC and RxSTBC - Style
  staging:rtl8192u: Remove DelayBA, PSMP and Rsvd1 - Style
  staging:rtl8192u: Remove LSigTxopProtect - Style
  staging:rtl8192u: Remove Rsvd2 - Style
  staging:rtl8192u: Remove ExtHTCapInfo - Style
  staging:rtl8192u: Remove TxBFCap - Style
  staging:rtl8192u: Remove ASCap - Style
  staging:rtl8192u: Remove potential memory leak

 .../staging/rtl8192u/ieee80211/ieee80211.h    |   3 -
 .../rtl8192u/ieee80211/ieee80211_module.c     |   5 +
 .../staging/rtl8192u/ieee80211/rtl819x_HT.h   |  20 +--
 .../rtl8192u/ieee80211/rtl819x_HTProc.c       | 123 ++++--------------
 4 files changed, 30 insertions(+), 121 deletions(-)

-- 
2.18.0