linux-kernel - Re: [PATCH -next] PCI: hotplug: Remove set but not used variable 'physical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180926192453.GD28024@bhelgaas-glaptop.roam.corp.google.com>
Date:   Wed, 26 Sep 2018 14:24:53 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Markus Elfring <elfring@...rs.sourceforge.net>,
        Frederick Lawler <fred@...dlawl.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Lukas Wunner <lukas@...ner.de>,
        Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-pci@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] PCI: hotplug: Remove set but not used variable
 'physical_slot'

On Wed, Sep 26, 2018 at 11:06:02AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/pci/hotplug/cpqphp_core.c: In function 'init_SERR':
> drivers/pci/hotplug/cpqphp_core.c:124:5: warning:
>  variable 'physical_slot' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied to pci/hotplug for v4.20, thanks!

> ---
>  drivers/pci/hotplug/cpqphp_core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c
> index 95b7d60..16bbb18 100644
> --- a/drivers/pci/hotplug/cpqphp_core.c
> +++ b/drivers/pci/hotplug/cpqphp_core.c
> @@ -121,7 +121,6 @@ static int init_SERR(struct controller *ctrl)
>  {
>  	u32 tempdword;
>  	u32 number_of_slots;
> -	u8 physical_slot;
>  
>  	if (!ctrl)
>  		return 1;
> @@ -131,7 +130,6 @@ static int init_SERR(struct controller *ctrl)
>  	number_of_slots = readb(ctrl->hpc_reg + SLOT_MASK) & 0x0F;
>  	/* Loop through slots */
>  	while (number_of_slots) {
> -		physical_slot = tempdword;
>  		writeb(0, ctrl->hpc_reg + SLOT_SERR);
>  		tempdword++;
>  		number_of_slots--;
>