linux-kernel - Re: [PATCH v1 2/7] dt-bindings: stm32-dmamux: Add one cell to support DMA/MDMA chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Sep 2018 15:22:17 -0500
From:   Rob Herring <robh@...nel.org>
To:     Pierre-Yves MORDRET <pierre-yves.mordret@...com>
Cc:     Vinod Koul <vkoul@...nel.org>, Mark Rutland <mark.rutland@....com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Dan Williams <dan.j.williams@...el.com>,
        devicetree@...r.kernel.org, dmaengine@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/7] dt-bindings: stm32-dmamux: Add one cell to
 support DMA/MDMA chain

On Tue, Sep 11, 2018 at 09:26:55AM +0200, Pierre-Yves MORDRET wrote:
> Add one cell to support DMA/MDMA chaining.

The diff doesn't match the description.

> 
> Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@...com>
> ---
>   Version history:
>     v1:
>        * Initial
> ---
> ---
>  Documentation/devicetree/bindings/dma/stm32-dmamux.txt | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/stm32-dmamux.txt b/Documentation/devicetree/bindings/dma/stm32-dmamux.txt
> index 1b893b2..8e092d2 100644
> --- a/Documentation/devicetree/bindings/dma/stm32-dmamux.txt
> +++ b/Documentation/devicetree/bindings/dma/stm32-dmamux.txt
> @@ -4,9 +4,6 @@ Required properties:
>  - compatible:	"st,stm32h7-dmamux"
>  - reg:		Memory map for accessing module
>  - #dma-cells:	Should be set to <3>.
> -		First parameter is request line number.
> -		Second is DMA channel configuration
> -		Third is Fifo threshold
>  		For more details about the three cells, please see
>  		stm32-dma.txt documentation binding file
>  - dma-masters:	Phandle pointing to the DMA controllers.
> @@ -53,7 +50,7 @@ dma2: dma@...20400 {
>  		     <68>,
>  		     <69>,
>  		     <70>;
> -	clocks = <&timer_clk>;
> +	clocks = <&clk_hclk>;
>  	#dma-cells = <4>;
>  	st,mem2mem;
>  	resets = <&rcc 150>;
> -- 
> 2.7.4
>