linux-kernel - Re: [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E999CEA6-97FA-4E89-A6B5-FF976EC0F0F5@cavium.com>
Date:   Wed, 26 Sep 2018 04:21:06 +0000
From:   "Madhani, Himanshu" <Himanshu.Madhani@...ium.com>
To:     Masanari Iida <standby24x7@...il.com>
CC:     Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...ium.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Malavali, Giridhar" <Giridhar.Malavali@...ium.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx


> On Sep 11, 2018, at 2:48 AM, Masanari Iida <standby24x7@...il.com> wrote:
> 
> External Email
> 
> Default value of ql2xasynctmfenable for qla2xxx driver was
> set to 1 in commit 043dc1d7e8501.
> But comment in MODULE_PARAM_DESC was not modified.
> 
> Signed-off-by: Masanari Iida <standby24x7@...il.com>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 42b8f0d3e580..fe5404be73c5 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -204,7 +204,7 @@ int ql2xasynctmfenable = 1;
> module_param(ql2xasynctmfenable, int, S_IRUGO);
> MODULE_PARM_DESC(ql2xasynctmfenable,
>                "Enables issue of TM IOCBs asynchronously via IOCB mechanism"
> -               "Default is 0 - Issue TM IOCBs via mailbox mechanism.");
> +               "Default is 1 - Issue TM IOCBs via mailbox mechanism.");
> 
> int ql2xdontresethba;
> module_param(ql2xdontresethba, int, S_IRUGO|S_IWUSR);
> --
> 2.19.0
> 

Thanks for the patch. 

Acked-by: Himanshu Madhani <himanshu.madhani@...ium.com>

-Himanshu