linux-kernel - Re: [PATCH 2/2] ARM: mvebu: Enable ARCH_WANT_LIBATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Sep 2018 13:05:49 +0700
From:   Aditya Prayoga <aditya@...ol.io>
To:     pavel@....cz
Cc:     linux-ide@...r.kernel.org, linux-leds@...r.kernel.org,
        jason@...edaemon.net, Andrew Lunn <andrew@...n.ch>,
        gregory.clement@...tlin.com,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        linux@...linux.org.uk, axboe@...nel.dk,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        jacek.anaszewski@...il.com, Daniel Golle <daniel@...rotopia.org>
Subject: Re: [PATCH 2/2] ARM: mvebu: Enable ARCH_WANT_LIBATA_LEDS in Armada 38x

On Thu, Sep 20, 2018 at 2:26 PM Pavel Machek <pavel@....cz> wrote:
>
> On Wed 2018-09-19 11:45:30, Aditya Prayoga wrote:
> > Enable hidden symbol ARCH_WANT_LIBATA_LEDS so CONFIG_ATA_LEDS can be
> > used in kernel configuration.
>
> Should that be hidden symbol and should that be architecture specific?
>

The intention was to minimize the risk of the ledtrig code being
included by accident. The
code itself does not have architecture specific instruction

> For a notebook, I may want scrolllock LED to indicate ATA activity
> (because I'm using USB keyboard and can't see the disk led).
>
> Hmm. And while at it... it would be nice to have option to watch all
> ATA ports combined, as well.

but there is disk-activity trigger for that purpose.

Aditya

>                                                                         Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html