linux-kernel - Re: [PATCH] staging: rtl8723bs: Remove ACPI table declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180926062245.GA5937@kroah.com>
Date:   Wed, 26 Sep 2018 08:22:45 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Remove ACPI table declaration

On Tue, Sep 25, 2018 at 10:39:10PM -0700, Nathan Chancellor wrote:
> Clang warns that the acpi_id declaration is not going to be emitted
> in the final assembly:
> 
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c:25:36: warning: variable
> 'acpi_ids' is not needed and will not be emitted
> [-Wunneeded-internal-declaration]
> static const struct acpi_device_id acpi_ids[] = {
>                                    ^
> 1 warning generated.
> 
> This is because it's marked as static const and it is not used anywhere
> in this file. Doing a git grep on this driver for 'acpi' shows that this
> declaration has been unused since the driver's initial induction. Remove
> it since it's not doing anything.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/169
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index 6d02904de63f..d473f9bd08c3 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -22,13 +22,7 @@ static const struct sdio_device_id sdio_ids[] =
>  	{ SDIO_DEVICE(0x024c, 0xb723), },
>  	{ /* end: all zeroes */				},
>  };
> -static const struct acpi_device_id acpi_ids[] = {
> -	{"OBDA8723", 0x0000},
> -	{}
> -};
> -
>  MODULE_DEVICE_TABLE(sdio, sdio_ids);
> -MODULE_DEVICE_TABLE(acpi, acpi_ids);

You just removed the ability for the driver to be automatically loaded
if that acpi id is present.

Not good :(

I think you need to fix up your scripts, this is valid code...

greg k-h