linux-kernel - Re: [PATCH v11 24/26] KVM: s390: device attrs to enable/disable AP interpretation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6c9170b-af24-3f9f-54fc-0d6f591b1067@redhat.com>
Date:   Wed, 26 Sep 2018 09:14:35 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Tony Krowiak <akrowiak@...ux.vnet.ibm.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     freude@...ibm.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, borntraeger@...ibm.com,
        cohuck@...hat.com, kwankhede@...dia.com,
        bjsdjshi@...ux.vnet.ibm.com, pbonzini@...hat.com,
        alex.williamson@...hat.com, pmorel@...ux.vnet.ibm.com,
        alifm@...ux.vnet.ibm.com, mjrosato@...ux.vnet.ibm.com,
        jjherne@...ux.vnet.ibm.com, thuth@...hat.com,
        pasic@...ux.vnet.ibm.com, berrange@...hat.com,
        fiuczy@...ux.vnet.ibm.com, buendgen@...ibm.com,
        frankja@...ux.ibm.com, Tony Krowiak <akrowiak@...ux.ibm.com>
Subject: Re: [PATCH v11 24/26] KVM: s390: device attrs to enable/disable AP
 interpretation

>  			ret = -ENXIO;
>  			break;
> @@ -2062,6 +2085,7 @@ static u64 kvm_s390_get_initial_cpuid(void)
>  static void kvm_s390_crypto_init(struct kvm *kvm)
>  {

Only two NITs,

>  	kvm->arch.crypto.crycb = &kvm->arch.sie_page2->crycb;
> +	kvm->arch.crypto.apie = 0;

This is not necessary (default is 0)

>  	kvm_s390_set_crycb_format(kvm);
>  
>  	if (!test_kvm_facility(kvm, 76))
> @@ -2601,6 +2625,7 @@ static void kvm_s390_vcpu_crypto_setup(struct kvm_vcpu *vcpu)
>  
>  	vcpu->arch.sie_block->crycbd = vcpu->kvm->arch.crypto.crycbd;
>  	vcpu->arch.sie_block->ecb3 &= ~(ECB3_AES | ECB3_DEA);
> +	vcpu->arch.sie_block->eca &= ~ECA_APIE;
>  

This probably should have been moved to patch 3.

Nothing to stop this from finding its way upstream.

-- 

Thanks,

David / dhildenb