linux-kernel - RE: [PATCH] platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB5PR05MB1640104C32067C3BE43CA529A2150@DB5PR05MB1640.eurprd05.prod.outlook.com>
Date:   Wed, 26 Sep 2018 07:43:22 +0000
From:   Vadim Pasternak <vadimp@...lanox.com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>
CC:     "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] platform/x86: mlx-platform: Properly use
 mlxplat_mlxcpld_msn201x_items



> -----Original Message-----
> From: Nathan Chancellor <natechancellor@...il.com>
> Sent: Wednesday, September 26, 2018 8:21 AM
> To: Vadim Pasternak <vadimp@...lanox.com>; Darren Hart
> <dvhart@...radead.org>; Andy Shevchenko <andy@...radead.org>
> Cc: platform-driver-x86@...r.kernel.org; linux-kernel@...r.kernel.org; Nathan
> Chancellor <natechancellor@...il.com>
> Subject: [PATCH] platform/x86: mlx-platform: Properly use
> mlxplat_mlxcpld_msn201x_items
> 
> Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be emitted in
> the final assembly because it's only used in ARRAY_SIZE right now, which is a
> compile time evaluation since the array's size is known.
> 
> drivers/platform/x86/mlx-platform.c:555:32: warning: variable
> 'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted [-
> Wunneeded-internal-declaration] static struct mlxreg_core_item
> mlxplat_mlxcpld_msn201x_items[] = {
>                                ^
> 1 warning generated.
> 
> It appears this was a copy and paste mistake from when this item was first
> added. Use the definition in mlxplat_mlxcpld_msn201x_data so that Clang no
> longer warns.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/141
> Fixes: a49a41482f61 ("platform/x86: mlx-platform: Add support for new
> msn201x system type")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---

Acked-by: Vadim Pasternak <vadimp@...lanox.com>

>  drivers/platform/x86/mlx-platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-
> platform.c
> index d89936c93ba0..c2c3a1a19879 100644
> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -575,7 +575,7 @@ static struct mlxreg_core_item
> mlxplat_mlxcpld_msn201x_items[] = {
> 
>  static
>  struct mlxreg_core_hotplug_platform_data mlxplat_mlxcpld_msn201x_data = {
> -	.items = mlxplat_mlxcpld_msn21xx_items,
> +	.items = mlxplat_mlxcpld_msn201x_items,
>  	.counter = ARRAY_SIZE(mlxplat_mlxcpld_msn201x_items),
>  	.cell = MLXPLAT_CPLD_LPC_REG_AGGR_OFFSET,
>  	.mask = MLXPLAT_CPLD_AGGR_MASK_DEF,
> --
> 2.19.0