[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cb029b9e-3a2c-a26c-56af-038a566715c6@huawei.com>
Date: Wed, 26 Sep 2018 09:46:31 +0100
From: John Garry <john.garry@...wei.com>
To: Xinliang Liu <xinliang.liu@...aro.org>
CC: "Liuxinliang (Matthew Liu)" <z.liuxinliang@...ilicon.com>,
XinWei Kong <kong.kongxinwei@...ilicon.com>,
Feng Chen <puck.chen@...ilicon.com>,
"David Airlie" <airlied@...ux.ie>,
Daniel Vetter <daniel.vetter@...ll.ch>, <baowenyi@...wei.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
dri-devel <dri-devel@...ts.freedesktop.org>,
Linuxarm <linuxarm@...wei.com>,
Rongrong Zou <zourongrong@...il.com>
Subject: Re: [PATCH 0/3] HiBMC driver fixes
On 26/09/2018 04:00, Xinliang Liu wrote:
> Thanks John, good addressing!
> The root cause as you said, our hibmc previous frame buffer format
> depth setting is wrong which does not pass the new format sanity
> checking drm_mode_legacy_fb_format.
> For this series, Reviewed-by: Xinliang Liu <z.liuxinliang@...ilicon.com>
> Applied to hisilicon-drm-next.
I can't see this branch in the git associated with this driver from its
MAINTAINERS entry (git://github.com/xin3liang/linux.git), but please
ensure these fixes are included in 4.19
Thanks,
John
>
> Thanks,
> Xinliang
>
> On Sun, 23 Sep 2018 at 20:32, John Garry <john.garry@...wei.com> wrote:
>>
>> This patchset fixes a couple of issues in probing the HiBMC driver, as
>> follows:
>> - fix the probe error path to not carry an error code in the pointer
>> - don't use invalid legacy fb bpp/depth combination
>>
>> Another more trivial patch is for using the standard Huawei PCI vendor ID
>> instead of hard-coding it.
>>
>> Tested on Huawei D05 board. I can see tux on BMC VGA console.
>>
>> John Garry (3):
>> drm/hisilicon: hibmc: Do not carry error code in HiBMC framebuffer
>> pointer
>> drm/hisilicon: hibmc: Don't overwrite fb helper surface depth
>> drm/hisilicon: hibmc: Use HUAWEI PCI vendor ID macro
>>
>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +-
>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> --
>> 1.9.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> .
>
Powered by blists - more mailing lists