linux-kernel - Re: [PATCH] platform/x86: ideapad-laptop: Use __func__ instead of read_ec_cmd in pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Sep 2018 12:28:56 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Ike Panhc <ike.pan@...onical.com>
Cc:     zhang.xianwei8@....com.cn, Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        zhong.weidong@....com.cn, jiang.biao2@....com.cn
Subject: Re: [PATCH] platform/x86: ideapad-laptop: Use __func__ instead of
 read_ec_cmd in pr_err

On Thu, Sep 6, 2018 at 11:49 AM Ike Panhc <ike.pan@...onical.com> wrote:
>
> On 09/04/2018 03:08 PM, Zhang Xianwei wrote:
> > Refer to the commit f1395edbcec8 ("platform/x86: ideapad-laptop: Use
> > __func__ instead of write_ec_cmd in pr_err"), prefer using '"%s...",
> > __func__' to using 'read_ec_cmd' in read_ec_data.
> >

Pushed to my review and testing queue, thanks!

> > Signed-off-by: Zhang Xianwei <zhang.xianwei8@....com.cn>
> > ---
> >  drivers/platform/x86/ideapad-laptop.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> > index d4f1259..f856d59 100644
> > --- a/drivers/platform/x86/ideapad-laptop.c
> > +++ b/drivers/platform/x86/ideapad-laptop.c
> > @@ -212,7 +212,7 @@ static int read_ec_data(acpi_handle handle, int cmd, unsigned long *data)
> >                       return 0;
> >               }
> >       }
> > -     pr_err("timeout in read_ec_cmd\n");
> > +     pr_err("timeout in %s\n", __func__);
> >       return -1;
> >  }
> >
> >
>
> Good catch. Thanks.
>
> Acked-by: Ike Panhc <ike.pan@...onical.com>
>


-- 
With Best Regards,
Andy Shevchenko