linux-kernel - Re: [PATCH] platform/x86: intel_int0002_vgpio: Enable the driver on Bay Trail platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Sep 2018 12:34:02 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: intel_int0002_vgpio: Enable the driver on
 Bay Trail platforms

On Wed, Sep 19, 2018 at 9:15 PM Hans de Goede <hdegoede@...hat.com> wrote:
>
> The intel_int0002_vgpio driver was added to avoid an IRQ 9 storm on Cherry
> Trail platforms.
>
> When originally merged the CPU ID for Bay Trail SoCs was commented out
> of the list of valid CPU IDs because we did not have any reports of the
> IRQ storm on Bay Trail platforms.
>
> We now have a report of the IRQ 9 storm on the Bay Trail based Thinkpad
> Tablet 10 which is fixed by enabling this driver, so lets enable it on
> Bay Trail too.
>
> I've tested various other Bay Trail device with this driver enabled
> without adverse side-effects.
>

Pushed to my review and testing queue, thanks!


> BugLink: https://www.dpin.de/nf/finally-s0i3-is-there-thinkpad-tablet-10-sleeps-deeply-with-linux-kernel-4-15rc/#comments
> Reported-and-tested-by: Nicole Faerber <nicole@...p.de>
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
>  drivers/platform/x86/intel_int0002_vgpio.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_int0002_vgpio.c b/drivers/platform/x86/intel_int0002_vgpio.c
> index a473dc51b18d..987a3b03f225 100644
> --- a/drivers/platform/x86/intel_int0002_vgpio.c
> +++ b/drivers/platform/x86/intel_int0002_vgpio.c
> @@ -57,11 +57,7 @@
>  #define ICPU(model)    { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, }
>
>  static const struct x86_cpu_id int0002_cpu_ids[] = {
> -/*
> - * Limit ourselves to Cherry Trail for now, until testing shows we
> - * need to handle the INT0002 device on Baytrail too.
> - *     ICPU(INTEL_FAM6_ATOM_SILVERMONT1),       * Valleyview, Bay Trail *
> - */
> +       ICPU(INTEL_FAM6_ATOM_SILVERMONT1),      /* Valleyview, Bay Trail  */
>         ICPU(INTEL_FAM6_ATOM_AIRMONT),          /* Braswell, Cherry Trail */
>         {}
>  };
> --
> 2.19.0.rc1
>


-- 
With Best Regards,
Andy Shevchenko