linux-kernel - Re: [PATCH 0/6] platform/x86: acerhdf: new BIOS string, better modparam handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VecQvirM=XXFCHQ7qn_hh+ix2u2HFq9u+JOOzcmjeRrdQ@mail.gmail.com>
Date:   Wed, 26 Sep 2018 14:13:47 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     peter@...e.net
Cc:     Paul Gortmaker <paul.gortmaker@...driver.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>
Subject: Re: [PATCH 0/6] platform/x86: acerhdf: new BIOS string, better
 modparam handling

On Wed, Sep 26, 2018 at 2:09 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Fri, Sep 21, 2018 at 9:20 AM Peter Feuerer <peter@...e.net> wrote:
> >
> > Hi,
> >
> > 21. September 2018 03:45, "Paul Gortmaker" <paul.gortmaker@...driver.com> schrieb:
> >
> > > I came across this older netbook over the xmas holidays, and noticed the
> > > acerhdf driver wouldn't load. Turns out the BIOS string was too new,
> > > and not listed in the driver. There were module params for overrides,
> > > but I found their use isn't quite clear without reading the source.
> > >
> > > Here I clarify some of the module parameter usage, and then add the new
> > > BIOS string, so they won't be needed for this particular platform. Some
> > > probe code is also shifted out to be __init to reduce the driver size a
> > > bit. Further details can be found in the respective commit logs.
> > >
> > > Since it was months ago when I created these patches, I retested on top
> > > of tree to ensure things still work, as can be seen below.
> >
> > Thanks a lot for your work and this set of changes.  This improves quality.
> > I reviewed all 6 patches.
> >
> > Reviewed-by: Peter Feuerer <peter@...e.net>
> >
> > Please also add CC: Boris Petkov <bp@...e.de> for review.
>
> Shall I wait for Boris'  tags?

Anyway, all suggested changes look good to me, I go ahead and push
them to my review and testing queue.
If nothing happens during let's say a week, I will move them forward.

Thanks!

-- 
With Best Regards,
Andy Shevchenko