linux-kernel - Re: [PATCH v4 1/3] dt-bindings: thermal: Add binding document for SR thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f20afabc-e712-8f35-8dd6-d42b9a0131f0@broadcom.com>
Date:   Thu, 27 Sep 2018 11:00:33 -0700
From:   Scott Branden <scott.branden@...adcom.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Rob Herring <robh@...nel.org>,
        Srinath Mannam <srinath.mannam@...adcom.com>
Cc:     daniel.lezcano@...aro.org, Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Pramod Kumar <pramod.kumar@...adcom.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: thermal: Add binding document for SR
 thermal



On 18-09-27 10:31 AM, Florian Fainelli wrote:
> On 09/27/2018 10:27 AM, Rob Herring wrote:
>> On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote:
>>> From: Pramod Kumar <pramod.kumar@...adcom.com>
>>>
>>> Add binding document for supported thermal implementation
>>> in Stingray.
>>>
>>> Signed-off-by: Pramod Kumar <pramod.kumar@...adcom.com>
>>> Signed-off-by: Srinath Mannam <srinath.mannam@...adcom.com>
>>> Reviewed-by: Ray Jui <ray.jui@...adcom.com>
>>> Reviewed-by: Scott Branden <scott.branden@...adcom.com>
>>> ---
>>>   .../bindings/thermal/brcm,sr-thermal.txt           | 25 ++++++++++++++++++++++
>>>   1 file changed, 25 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>>> new file mode 100644
>>> index 0000000..717617b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>>> @@ -0,0 +1,25 @@
>>> +* Broadcom Stingray Thermal
>>> +
>>> +This binding describes thermal sensors that is part of Stingray SoCs.
>>> +
>>> +Required properties:
>>> +- compatible : Must be "brcm,sr-thermal"
>>> +- reg : memory where tmon data will be available.
>>> +- brcm,tmon-mask: A one cell bit mask of valid TMON sources.
>>> +                  Each bit represents single TMON source.
>>> +- brcm,max-crit-temp: Maximum supported critical temperature.
>> We already have a defined binding for setting trip points.
> Indeed, and if you have multiple TMONs, they would in premise possibly
> each have a different critical trip point.
Which may be a good reason to go back to our original bindings which 
were generic and had each sensor in its own node?
>>> +
>>> +Example:
>>> +	tmons {
>>> +		compatible = "simple-bus";
>>> +		#address-cells = <1>;
>>> +		#size-cells = <1>;
>>> +		ranges = <0x0 0x0 0x8f100000 0x100>;
>>> +
>>> +		tmon: thermal@0 {
>>> +			compatible = "brcm,sr-thermal";
>>> +			reg = <0 0x40>;
>>> +			brcm,tmon-mask = <0x3f>;
>>> +			brcm,max-crit-temp = <105000>;
>>> +		};
>>> +	};
>>> -- 
>>> 2.7.4
>>>
>