linux-kernel - Re: [PATCH] crypto/morus(640,1280)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Sep 2018 21:28:32 +0200
From:   Ondrej Mosnáček <omosnacek@...il.com>
To:     valdis.kletnieks@...edu
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto/morus(640,1280) - make crypto_...-algs static

št 27. 9. 2018 o 0:50 <valdis.kletnieks@...edu> napísal(a):
> sparse complains thusly:
>
>   CHECK   arch/x86/crypto/morus640-sse2-glue.c
> arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol 'crypto_morus640_sse2_algs' was not declared. Should it be static?
>   CHECK   arch/x86/crypto/morus1280-sse2-glue.c
> arch/x86/crypto/morus1280-sse2-glue.c:38:1: warning: symbol 'crypto_morus1280_sse2_algs' was not declared. Should it be static?
>   CHECK   arch/x86/crypto/morus1280-avx2-glue.c
> arch/x86/crypto/morus1280-avx2-glue.c:38:1: warning: symbol 'crypto_morus1280_avx2_algs' was not declared. Should it be static?
>
> and sparse is correct - these don't need to be global and polluting the namespace.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>

Indeed, this should be fixed, thanks!

Acked-by: Ondrej Mosnacek <omosnacek@...il.com>

> ---
> diff --git a/include/crypto/morus1280_glue.h b/include/crypto/morus1280_glue.h
> index b26dd70efd9a..ba782e10065e 100644
> --- a/include/crypto/morus1280_glue.h
> +++ b/include/crypto/morus1280_glue.h
> @@ -82,7 +82,7 @@ void cryptd_morus1280_glue_exit_tfm(struct crypto_aead *aead);
>         { \
>         } \
>         \
> -       struct aead_alg crypto_morus1280_##id##_algs[] = {\
> +       static struct aead_alg crypto_morus1280_##id##_algs[] = {\
>                 { \
>                         .setkey = crypto_morus1280_glue_setkey, \
>                         .setauthsize = crypto_morus1280_glue_setauthsize, \
> diff --git a/include/crypto/morus640_glue.h b/include/crypto/morus640_glue.h
> index 90c8db07e740..27fa790a2362 100644
> --- a/include/crypto/morus640_glue.h
> +++ b/include/crypto/morus640_glue.h
> @@ -82,7 +82,7 @@ void cryptd_morus640_glue_exit_tfm(struct crypto_aead *aead);
>         { \
>         } \
>         \
> -       struct aead_alg crypto_morus640_##id##_algs[] = {\
> +       static struct aead_alg crypto_morus640_##id##_algs[] = {\
>                 { \
>                         .setkey = crypto_morus640_glue_setkey, \
>                         .setauthsize = crypto_morus640_glue_setauthsize, \
>