linux-kernel - Re: [PATCH v7 2/2] hwmon: ina3221: Read channel input source info from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180927221111.GA29012@Asurada-Nvidia.nvidia.com>
Date:   Thu, 27 Sep 2018 15:11:12 -0700
From:   Nicolin Chen <nicoleotsuka@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     jdelvare@...e.com, robh+dt@...nel.org, mark.rutland@....com,
        corbet@....net, afd@...com, linux-hwmon@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH v7 2/2] hwmon: ina3221: Read channel input source info
 from DT

On Thu, Sep 27, 2018 at 03:06:20PM -0700, Guenter Roeck wrote:
 
> I am quite sure I asked to use kstrtobool(). Did that get lost or do you have
> some reason to not use it ?
> 
> I can understand if you don't want to change ina3221_is_enable() to
> ina3221_is_enabled(), since that is POV, but I don't really understand
> why you did not make the other changes. Am I missing something ?

Sorry, my fault. It's not really "I don't want to" but I missed the
part in that review. Will fix them all.

Thanks
Nicolin