linux-kernel - Re: [PATCH 2/5] usb: host: Add OHCI driver for Broadcom STB SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0rN=E7vnK3Ri8srXBDT7cdsVj-n=G6VGBROc0o8vrcpw@mail.gmail.com>
Date:   Thu, 27 Sep 2018 11:08:39 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Al Cooper <alcooperx@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        gregkh <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alan Stern <stern@...land.harvard.edu>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        David Miller <davem@...emloft.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dmitry Osipenko <digetx@...il.com>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        sunjianguo1@...wei.com, James Hogan <jhogan@...nel.org>,
        Alban Bedel <albeu@...e.fr>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Avi Fishman <avifishman70@...il.com>,
        Alex Elder <elder@...aro.org>,
        Hans de Goede <hdegoede@...hat.com>,
        USB list <linux-usb@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH 2/5] usb: host: Add OHCI driver for Broadcom STB SoCs

On Thu, Sep 27, 2018 at 12:20 AM Al Cooper <alcooperx@...il.com> wrote:
>
> This driver enables USB OHCI on Broadcom ARM and MIPS STB SoCs.
> The drivers depend on a matching "brcm,brcmstb-usb-phy"
> Broadcom STB USB Phy driver.
>
> The standard platform driver can't be used because of differences
> in PHY and Clock handling. The standard PHY handling in hcd.c will
> do a phy_exit/phy_init on suspend/resume and this will end up
> shutting down the PHYs to the point that the host controller
> registers are no longer accessible and will cause suspend to crash.
> The clocks specified in device tree for these drivers are not
> available in mainline so instead of returning EPROBE_DEFER when
> the specified clock is not found and eventually failing probe,
> the clock pointer is set to NULL which disables all clock handling.

Both of these sound like fairly minor differences, I wonder if the
generic code could be adapted to have a special case for these
rather than duplicating it.

        Arnd