linux-kernel - Re: [PATCH 4.14 64/64] crypto: x86/aegis,morus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Sep 2018 14:40:05 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Stable <stable@...r.kernel.org>,
        Zdenek Kaspar <zkaspar82@...il.com>,
        Ondrej Mosnacek <omosnace@...hat.com>,
        Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH 4.14 64/64] crypto: x86/aegis,morus - Do not require
 OSXSAVE for SSE2

On Thu, Sep 27, 2018 at 12:30:04PM +0100, Sudip Mukherjee wrote:
> Hi Greg,
> 
> On Thu, Sep 27, 2018 at 10:04 AM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> > 4.14-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Ondrej Mosnacek <omosnace@...hat.com>
> >
> > commit 24568b47d48ec8c906fd0f589489a08b17e1edca upstream.
> >
> > It turns out OSXSAVE needs to be checked only for AVX, not for SSE.
> > Without this patch the affected modules refuse to load on CPUs with SSE2
> > but without AVX support.
> >
> > Fixes: 877ccce7cbe8 ("crypto: x86/aegis,morus - Fix and simplify CPUID checks")
> > Cc: <stable@...r.kernel.org> # 4.18
> > Reported-by: Zdenek Kaspar <zkaspar82@...il.com>
> > Signed-off-by: Ondrej Mosnacek <omosnace@...hat.com>
> > Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> I am confused with this one. I am not seeing this in the "git log"
> from your 4.14.73-rc1.
> I also tried to apply this from your queue to v4.14.72 and it did not
> apply as it could not
> find some files.
> 
> error: arch/x86/crypto/aegis128-aesni-glue.c: No such file or directory
> error: arch/x86/crypto/aegis128l-aesni-glue.c: No such file or directory
> error: arch/x86/crypto/aegis256-aesni-glue.c: No such file or directory
> error: arch/x86/crypto/morus1280-sse2-glue.c: No such file or directory
> error: arch/x86/crypto/morus640-sse2-glue.c: No such file or directory
> 
> Am I missing something?

Nope, my fault, it was at the end of my quilt queue and should have been
deleted.  My scripts didn't catch the error, which is odd.

Now dropped, thanks.

greg k-h