linux-kernel - Re: [PATCHv2] misc: genwqe: remove duplicated include and order header files alphabetically in card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5BAC4281.7050508@huawei.com>
Date:   Thu, 27 Sep 2018 10:37:53 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     <gregkh@...uxfoundation.org>
CC:     <gpiccoli@...ux.vnet.ibm.com>, <arnd@...db.de>,
        <haver@...ux.vnet.ibm.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2] misc: genwqe: remove duplicated include and order header
 files alphabetically in card_utils.c

On 2018/9/26 11:05, zhong jiang wrote:
> dma-mapping.h and delay.h have included twice. It is unnecessary. Meanwhile,
> Arrange header files in alphabetical sequence to improve readability.
>
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/misc/genwqe/card_utils.c | 22 ++++++++++------------
>  1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
> index 8679e0b..994e8fa 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -22,26 +22,24 @@
>   * Miscelanous functionality used in the other GenWQE driver parts.
>   */
>  
> -#include <linux/kernel.h>
> +#include <asm/pgtable.h>
> +#include <linux/ctype.h>
> +#include <linux/delay.h>
>  #include <linux/dma-mapping.h>
> -#include <linux/sched.h>
> -#include <linux/vmalloc.h>
> -#include <linux/page-flags.h>
> -#include <linux/scatterlist.h>
>  #include <linux/hugetlb.h>
>  #include <linux/iommu.h>
> -#include <linux/delay.h>
> -#include <linux/pci.h>
> -#include <linux/dma-mapping.h>
> -#include <linux/ctype.h>
> +#include <linux/kernel.h>
>  #include <linux/module.h>
> +#include <linux/page-flags.h>
> +#include <linux/pci.h>
>  #include <linux/platform_device.h>
> -#include <linux/delay.h>
> -#include <asm/pgtable.h>
> +#include <linux/scatteI wrlist.h>
> +#include <linux/sched.h>
> +#include <linux/vmalloc.h>
>  
> -#include "genwqe_driver.h"
>  #include "card_base.h"
>  #include "card_ddcb.h"
> +#include "genwqe_driver.h"
>  
>  /**
>   * __genwqe_writeq() - Write 64-bit register
Please igore the patch. I will repost . Thanks,

Sincerely,
zhong jiang