linux-kernel - Re: [PATCH v2] qed: Avoid implicit enum conversion in qed_roce_mode_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180926.201940.800778593716150299.davem@davemloft.net>
Date:   Wed, 26 Sep 2018 20:19:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     Ariel.Elior@...ium.com, everest-linux-l2@...ium.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] qed: Avoid implicit enum conversion in
 qed_roce_mode_to_flavor

From: Nathan Chancellor <natechancellor@...il.com>
Date: Mon, 24 Sep 2018 14:34:53 -0700

> Clang warns when one enumerated type is implicitly converted to another.
> 
> drivers/net/ethernet/qlogic/qed/qed_roce.c:153:12: warning: implicit
> conversion from enumeration type 'enum roce_mode' to different
> enumeration type 'enum roce_flavor' [-Wenum-conversion]
>                 flavor = ROCE_V2_IPV6;
>                        ~ ^~~~~~~~~~~~
> drivers/net/ethernet/qlogic/qed/qed_roce.c:156:12: warning: implicit
> conversion from enumeration type 'enum roce_mode' to different
> enumeration type 'enum roce_flavor' [-Wenum-conversion]
>                 flavor = MAX_ROCE_MODE;
>                        ~ ^~~~~~~~~~~~~
> 2 warnings generated.
> 
> Use the appropriate values from the expected type, roce_flavor:
> 
> ROCE_V2_IPV6 = RROCE_IPV6 = 2
> MAX_ROCE_MODE = MAX_ROCE_FLAVOR = 3
> 
> While we're add it, ditch the local variable flavor, we can just return
> the value directly from the switch statement.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/125
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
> 
> v1 -> v2:
> 
> * s/if statement/switch statement/ in commit message

Applied.