linux-kernel - Re: [PATCH v11 26/26] s390: doc: detailed specifications for AP virtualization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4c72d185-c627-f839-2bb0-bda33b647cd8@de.ibm.com>
Date:   Fri, 28 Sep 2018 09:20:35 +0200
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Tony Krowiak <akrowiak@...ux.ibm.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Tony Krowiak <akrowiak@...ux.vnet.ibm.com>
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, freude@...ibm.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, cohuck@...hat.com, kwankhede@...dia.com,
        bjsdjshi@...ux.vnet.ibm.com, pbonzini@...hat.com,
        pmorel@...ux.vnet.ibm.com, alifm@...ux.vnet.ibm.com,
        mjrosato@...ux.vnet.ibm.com, jjherne@...ux.vnet.ibm.com,
        thuth@...hat.com, pasic@...ux.vnet.ibm.com, berrange@...hat.com,
        fiuczy@...ux.vnet.ibm.com, buendgen@...ibm.com,
        frankja@...ux.ibm.com
Subject: Re: [PATCH v11 26/26] s390: doc: detailed specifications for AP
 virtualization



On 09/27/2018 09:19 PM, Tony Krowiak wrote:
> On 09/26/2018 06:42 PM, Alex Williamson wrote:
>> On Tue, 25 Sep 2018 19:16:41 -0400
>> Tony Krowiak <akrowiak@...ux.vnet.ibm.com> wrote:
>>
>>> From: Tony Krowiak <akrowiak@...ux.ibm.com>
>>>
>>> This patch provides documentation describing the AP architecture and
>>> design concepts behind the virtualization of AP devices. It also
>>> includes an example of how to configure AP devices for exclusive
>>> use of KVM guests.
>>>
>>> Signed-off-by: Tony Krowiak <akrowiak@...ux.ibm.com>
>>> Reviewed-by: Halil Pasic <pasic@...ux.ibm.com>
>>> ---
>>>   Documentation/s390/vfio-ap.txt | 782 +++++++++++++++++++++++++++++++++
>>>   MAINTAINERS                    |   1 +
>>>   2 files changed, 783 insertions(+)
>>>   create mode 100644 Documentation/s390/vfio-ap.txt
>> ...
>>> +Example:
>>> +=======
>>> +Let's now provide an example to illustrate how KVM guests may be given
>>> +access to AP facilities. For this example, we will show how to configure
>>> +three guests such that executing the lszcrypt command on the guests would
>>> +look like this:
>>> +
>>> +Guest1
>>> +------
>>> +CARD.DOMAIN TYPE  MODE
>>> +------------------------------
>>> +05          CEX5C CCA-Coproc
>>> +05.0004     CEX5C CCA-Coproc
>>> +05.00ab     CEX5C CCA-Coproc
>>> +06          CEX5A Accelerator
>>> +06.0004     CEX5A Accelerator
>>> +06.00ab     CEX5C CCA-Coproc
>>> +
>>> +Guest2
>>> +------
>>> +CARD.DOMAIN TYPE  MODE
>>> +------------------------------
>>> +05          CEX5A Accelerator
>>> +05.0047     CEX5A Accelerator
>>> +05.00ff     CEX5A Accelerator (5,4), (5,171), (6,4), (6,171),
>>                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> Seems like an unfinished thought here.

Can you submit another fixup that takes care of this comment?