linux-kernel - Re: [PATCH V5 23/30] dt-bindings: interrupt-controller: C-SKY SMP intc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Sep 2018 09:07:23 +0800
From:   Guo Ren <ren_guo@...ky.com>
To:     Rob Herring <robh@...nel.org>
Cc:     akpm@...ux-foundation.org, arnd@...db.de,
        daniel.lezcano@...aro.org, davem@...emloft.net,
        gregkh@...uxfoundation.org, jason@...edaemon.net,
        marc.zyngier@....com, mark.rutland@....com,
        mchehab+samsung@...nel.org, peterz@...radead.org,
        tglx@...utronix.de, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org, devicetree@...r.kernel.org,
        green.hu@...il.com, palmer@...ive.com
Subject: Re: [PATCH V5 23/30] dt-bindings: interrupt-controller: C-SKY SMP
 intc

On Thu, Sep 27, 2018 at 11:50:44AM -0500, Rob Herring wrote:
> On Tue, Sep 25, 2018 at 07:39:26AM +0800, Guo Ren wrote:
> >  - Dt-bindings doc about C-SKY Multi-processors interrupt controller.
> > 
> > Signed-off-by: Guo Ren <ren_guo@...ky.com>
> > ---
> >  .../bindings/interrupt-controller/csky,mpintc.txt  | 40 ++++++++++++++++++++++
> >  1 file changed, 40 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt b/Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt
> > new file mode 100644
> > index 0000000..9cdad74
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt
> > @@ -0,0 +1,40 @@
> > +===========================================
> > +C-SKY Multi-processors Interrupt Controller
> > +===========================================
> > +
> > +C-SKY Multi-processors Interrupt Controller is designed for ck807/ck810/ck860
> > +SMP soc, and it also could be used in non-SMP system.
> > +
> > +Interrupt number definition:
> > +
> > +  0-15  : software irq, and we use 15 as our IPI_IRQ.
> > + 16-31  : private  irq, and we use 16 as the co-processor timer.
> > + 31-1024: common irq for soc ip.
> > +
> > +=============================
> > +intc node bindings definition
> > +=============================
> > +
> > +	Description: Describes SMP interrupt controller
> > +
> > +	PROPERTIES
> > +
> > +	- compatible
> > +		Usage: required
> > +		Value type: <string>
> > +		Definition: must be "csky,mpintc"
> 
> Only 1 version?
Currently, one version. Only one csky,mpintc.

> 
> This is fine for a fallback, but you should have an SoC specific 
> compatible too in case there are any SoC specific errata/quirks.
No SoC specific in fact currently. If necessary we could add it in future.

> 
> > +	- interrupt-cells
> 
> Should be: #interrupt-cells
Yes, I'll fix it.