linux-kernel - Re: [PATCH] PCI/AER: Clear uncorrectable error status for device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e7b35f31-c684-ddac-7393-435640c6af39@kernel.org>
Date:   Fri, 28 Sep 2018 09:58:27 -0400
From:   Sinan Kaya <okaya@...nel.org>
To:     poza@...eaurora.org, Bjorn Helgaas <helgaas@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        linux-pci@...r.kernel.org, Keith Busch <keith.busch@...el.com>,
        Wei Zhang <wzhang@...com>, linux-kernel@...r.kernel.org,
        Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        Dan Williams <dan.j.williams@...el.com>,
        Kees Cook <keescook@...omium.org>,
        Sagi Grimberg <sagi@...mberg.me>,
        Adaptec OEM Raid Solutions <aacraid@...rosemi.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH] PCI/AER: Clear uncorrectable error status for device

On 9/28/2018 6:24 AM, poza@...eaurora.org wrote:
> 1) Does that seem like the right place?
> 

IMO, I think best is to call after driver callback in PCI core.
A driver specific action can cause some of these errors.
We don't want to return with outstanding errors.

> 2) I guess all we need now would be to remove the calls from the
>     drivers?
> 

yes

> 3) If we remove all the calls from the drivers, we should remove the
>     declaration from include/linux/aer.h, too.
> 

makes sense

> I can take care of these updates if we agree they're the right thing
> to do.