linux-kernel - Re: [PATCH 4/9] fuse: allow caching readdir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180928164204.GA20414@bombadil.infradead.org>
Date:   Fri, 28 Sep 2018 09:42:04 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Miklos Szeredi <mszeredi@...hat.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/9] fuse: allow caching readdir

On Fri, Sep 28, 2018 at 05:42:29PM +0200, Miklos Szeredi wrote:
> @@ -103,6 +103,21 @@ struct fuse_inode {
>  	/** List of writepage requestst (pending or sent) */
>  	struct list_head writepages;
>  
> +	/** readdir cache */
> +	struct {
> +		/** true if fully cached */
> +		bool cached;

umm, you're using kernel-doc markers without formatting this comment as
kernel-doc.  See Documentation/doc-guide/kernel-doc.rst but I believe
you should be writing this as:

		/** @rdc.cached: true if fully cached */

or just use /* */ if you don't want kernel-doc.